Wireshark-commits: [Wireshark-commits] master a8a4098: "Color dissector filters" are just filters.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Oct 2015 03:32:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8a4098e12b1b60548ce1a1887b2a18a54ef790f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a8a4098 by Guy Harris (guy@xxxxxxxxxxxx):

    "Color dissector filters" are just filters.
    
    Rename the color_dissector_filters.[ch] files to just
    dissector_filters.[ch], and rename the routines not to include the
    string "color_", as those filters can be used as color filters *or*
    display filters.
    
    Remove "color_" from other places where we're not doing colorization.
    
    In the GTK+ code, combine the two loops that add menu items for filters
    in the dissector-provided filters list into one.
    
    Change-Id: I08ecccc6b1b1be675e4129a0589f36c9f240407c
    Reviewed-on: https://code.wireshark.org/review/11379
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  0257a30   HSRP(v2): Always display all fields (Like Padding...)
    adds  a8a4098   "Color dissector filters" are just filters.


Summary of changes:
 epan/CMakeLists.txt                                |    2 +-
 epan/Makefile.common                               |    4 +-
 ...lor_dissector_filters.c => dissector_filters.c} |   30 ++---
 ...lor_dissector_filters.h => dissector_filters.h} |   34 +++---
 epan/dissectors/packet-enip.c                      |    6 +-
 epan/dissectors/packet-eth.c                       |    8 +-
 epan/dissectors/packet-ip.c                        |    8 +-
 epan/dissectors/packet-ipv6.c                      |    8 +-
 epan/dissectors/packet-tcp.c                       |    8 +-
 epan/dissectors/packet-udp.c                       |    8 +-
 plugins/profinet/packet-dcerpc-pn-io.c             |    6 +-
 plugins/profinet/packet-dcom-cba-acco.c            |    8 +-
 ui/gtk/main_menubar.c                              |  118 +++++++++-----------
 ui/qt/main_window_slots.cpp                        |   40 +++----
 14 files changed, 137 insertions(+), 151 deletions(-)
 rename epan/{color_dissector_filters.c => dissector_filters.c} (61%)
 rename epan/{color_dissector_filters.h => dissector_filters.h} (57%)