Wireshark-commits: [Wireshark-commits] master-2.0 9d02d9f: NULL terminate some hf_ arrays used in p

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Oct 2015 01:45:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d02d9f07a04b68a71d305288c6007716439f32d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9d02d9f by Michael Mann (mmann78@xxxxxxxxxxxx):

    NULL terminate some hf_ arrays used in proto_tree_add_bitmask_xxx calls.
    
    I thought this was already caught by one of the check*.pl scripts, but I ran into the one in packet-nfs.c and decided to manually check the dissector directory.
    
    Change-Id: I8df83227255818eabc43763e3cf760cf762797cc
    Reviewed-on: https://code.wireshark.org/review/11230
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 3385c2951c7dfecaaf0aad871a0842319d386321)
    Reviewed-on: https://code.wireshark.org/review/11237
    

Actions performed:

    from  02775bb   802.1ah: call subdissectors even when we have no tree.
    adds  9d02d9f   NULL terminate some hf_ arrays used in proto_tree_add_bitmask_xxx calls.


Summary of changes:
 epan/dissectors/packet-nfs.c   |    1 +
 epan/dissectors/packet-ocfs2.c |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)