Wireshark-commits: [Wireshark-commits] master 317af2c: x509af: dissect subjectPublicKey for RSA

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 18 Oct 2015 03:30:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=317af2c68ce1db0599fb0082cf454a451ff74c20
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

317af2c by Peter Wu (peter@xxxxxxxxxxxxx):

    x509af: dissect subjectPublicKey for RSA
    
    The subjectPublicKey field of a Certificate (TBSCertificate) is defined
    as type BIT STRING. The actual contents depend on the Algorithm
    Identifier which is preceding the subjectPublicKey field.
    
    This patch adds support for dissection of the public key for RSA
    public keys which show up below the subjectPublicKey tree:
    
        subjectPublicKeyInfo
            algorithm (rsaEncryption)
                Algorithm Id: 1.2.840.113549.1.1.1 (rsaEncryption)
            subjectPublicKey: 3082010a0282010100b7c769e2d0eacaeb929fc08238a9ff...
                modulus : 0x00b7c769e2d0eacaeb929fc08238a9ffc59cab39c28a2e26...
                publicExponent: 65537
    
    Change-Id: Ib92645433b0a0078a947ff0ac26c5e6a64877b93
    Reviewed-on: https://code.wireshark.org/review/10967
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  48d46e6   Don't parse services file twice, respect user settings
    adds  317af2c   x509af: dissect subjectPublicKey for RSA


Summary of changes:
 asn1/pkcs1/pkcs1.cnf                 |    3 ++
 asn1/x509af/packet-x509af-template.c |    1 +
 asn1/x509af/x509af.cnf               |   26 +++++++++++++++
 epan/dissectors/packet-pkcs1.c       |    2 +-
 epan/dissectors/packet-x509af.c      |   58 ++++++++++++++++++++++++----------
 5 files changed, 73 insertions(+), 17 deletions(-)