Wireshark-commits: [Wireshark-commits] master-2.0 aa39ec8: CMake: Don't feed -fPIC to Visual C++, s

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 15 Oct 2015 18:29:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa39ec8b0444d7be6c6b0d828c3a39373c397de3
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

aa39ec8 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CMake: Don't feed -fPIC to Visual C++, second try.
    
    Qt5CoreConfigExtras.cmake in Qt 5.5.0 sets -fPIC unconditionally.
    
    Change-Id: Idf88b0f34b7cec40530702350b417ce1924db9f1
    Reviewed-on: https://code.wireshark.org/review/11050
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 6ea71d9ad280be4f283ef7b44685270fca3b9e6b)
    Reviewed-on: https://code.wireshark.org/review/11062
    

Actions performed:

    from  5587f3b   nstime: fix -Wshift-negative-value
    adds  aa39ec8   CMake: Don't feed -fPIC to Visual C++, second try.


Summary of changes:
 CMakeLists.txt |    5 +++++
 1 file changed, 5 insertions(+)