Wireshark-commits: [Wireshark-commits] master c5a0568: Try to fix wireless toolbar behavior on Linu

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Oct 2015 15:50:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5a056832dc9e3afaeb89beb6feedf134287183c
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c5a0568 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Try to fix wireless toolbar behavior on Linux.
    
    Split interface get and set activity into explicit getInterfaceInfo and
    setInterfaceInfo member functions. Make sure we connect to QComboBox
    "activated" signals (which are only triggered by user activity)
    instead of "currentIndexChanged" signals (which are triggered on
    any change). Hopefully this will make the wireless toolbar read-only
    until the user selects a combobox item.
    
    Bug: 11487
    Change-Id: I236ff3f5972b0b7d543f21bb955d7892190a7814
    Reviewed-on: https://code.wireshark.org/review/10918
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  23beb97   extcap: fix a bug in create_tempfile() return check (CID 1323930)
    adds  c5a0568   Try to fix wireless toolbar behavior on Linux.


Summary of changes:
 ui/qt/wireless_frame.cpp |   50 +++++++++++++++++++++++++++++++---------------
 ui/qt/wireless_frame.h   |    8 ++++----
 2 files changed, 38 insertions(+), 20 deletions(-)