Wireshark-commits: [Wireshark-commits] master 4a45bd5: Display of reserved octet in 6lowpan IPHC he

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 9 Oct 2015 23:34:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a45bd5bf486d7d9e5bc93478e1ee286bb301775
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a45bd5 by Pedro Jose Marron (pjmarron@xxxxxxxxxxxx):

    Display of reserved octet in 6lowpan IPHC header
    
    The 6lowpan standard specifies a reserved octet in the extended header
    of an IP_PROTO_FRAGMENT packet in the same place used for the header
    length for other extension headers.
    
    The current version of the 6lowpan dissector displays the reserved octet
    and the rest of the header (6 more bytes) together as data, as opposed to
    displaying the reserved octet by itself and then the data (using the
    data dissector).
    
    This patch does not change the functionality of the dissector in any
    way, only how the 7 bytes are displayed. Instead of displaying the
    header information and then 7 bytes of data, it displays the reserved
    octet and then the data. This is also consistent with the way the ipv6
    dissector displays it (showing the reserved octet and its value).
    
    For this purpose, there is a new hf (hf_6lowpan_nhc_ext_reserved) and
    the corresponding proto_tree calls. Also, depending on the type of
    extension header, the octets sent to the general data dissector are
    shifted by one.
    
    Change-Id: I4c7fb58a3364307e79517b979808f3e34a2e0b94
    Reviewed-on: https://code.wireshark.org/review/10908
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b072267   nstime: fix -Wshift-negative-value
    adds  4a45bd5   Display of reserved octet in 6lowpan IPHC header


Summary of changes:
 epan/dissectors/packet-6lowpan.c |   16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)