Wireshark-commits: [Wireshark-commits] master 082b0d7: Fix an I/O graph crash.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 Oct 2015 15:23:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=082b0d7ba279b0a87eb2620f2875b77fd24e7931
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

082b0d7 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Fix an I/O graph crash.
    
    QTreeWidget::removeItemWidget calls QAbstractItemView::setIndexWidget, 
    which deletes the current item widget. As a result we shouldn't try to
    delete itemWidgets ourselves.
    
    Add a note explaining why we use hand-crafted item widgets instead of a
    custom item delegate.
    
    Bug: 11449
    Change-Id: I485bacc0fae60ea3174e003ef0032948ee5c720f
    Reviewed-on: https://code.wireshark.org/review/10820
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  12b735d   [NSIP] Wrong offset used for proto_tree_add_bitmask() for the reset flag.
    adds  082b0d7   Fix an I/O graph crash.


Summary of changes:
 ui/qt/io_graph_dialog.cpp |   43 +++++++++++--------------------------------
 ui/qt/io_graph_dialog.h   |    2 --
 2 files changed, 11 insertions(+), 34 deletions(-)