URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d0060100a03269c18c70a23622e44bb19dd0355
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
2d00601 by Pascal Quantin (pascal.quantin@xxxxxxxxx):
Qt: fix crash when double clicking on a row in 'Decode As' dialog
No need to register for the destroyed() signal: it is emitted after the new
QComboBox object is created and resetting pointers to NULL is useless as they
are locals initialized in the constructor
Bug: 11532
Change-Id: Ie707cafa370053df846a4732aed20c182e030c40
Reviewed-on: https://code.wireshark.org/review/10792
Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
(cherry picked from commit 3f56b5e6b91ec2d57c8ce48606332368c17665dd)
Reviewed-on: https://code.wireshark.org/review/10811
Actions performed:
from 6fb0a48 Copy over git-compare-apis from master-1.12.
adds 2d00601 Qt: fix crash when double clicking on a row in 'Decode As' dialog
Summary of changes:
ui/qt/decode_as_dialog.cpp | 21 ++-------------------
ui/qt/decode_as_dialog.h | 3 ---
2 files changed, 2 insertions(+), 22 deletions(-)