URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c647faa8a90739963ba40a099a365197f90b2184
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
c647faa by Peter Wu (peter@xxxxxxxxxxxxx):
Fix various memleaks
Found by starting Wireshark within an empty profile, opening
Preferences, search for Protocol "IEEE 802.11" (because it has radio
buttons), then close everything again.
Many fixes are trivial, but the various recent_read_* functions in
recent.c were changed to return a boolean such that the result can
always be checked even if errno==0.
QButtonGroup leak was hinted by Clang Static Analyzer, all other
memleaks were found using ASAN/LSan.
Change-Id: Ia73f5d4c09d92f22e72377be59e23342f8ad7211
Reviewed-on: https://code.wireshark.org/review/10776
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from 49151eb [Automatic update for 2015-10-04]
adds c647faa Fix various memleaks
Summary of changes:
capchild/capture_ifinfo.c | 1 +
caputils/capture-pcap-util.c | 1 +
epan/prefs.c | 1 +
ui/capture.c | 1 +
ui/gtk/main.c | 12 ++++++------
ui/iface_lists.c | 20 ++++++++++----------
ui/qt/main_welcome.cpp | 5 +++++
ui/qt/main_welcome.h | 1 +
ui/qt/module_preferences_scroll_area.cpp | 2 +-
ui/qt/wireshark_application.cpp | 4 ++--
ui/recent.c | 21 ++++++++++++---------
ui/recent.h | 9 ++++++---
wireshark-qt.cpp | 16 ++++++++--------
13 files changed, 55 insertions(+), 39 deletions(-)