Wireshark-commits: [Wireshark-commits] master 1d0532f: qt: warn when jumping to an invalid packet n

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 30 Sep 2015 12:40:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d0532fee52bcb507c91ad1b500fb0965951c6b1
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1d0532f by Peter Wu (peter@xxxxxxxxxxxxx):

    qt: warn when jumping to an invalid packet number
    
    I was confused when double-clicking a packet number did not work. It
    turns out that the display filter was hiding the destination.
    
    Check the packet number for sanity, just like GTK+ does.
    
    Change-Id: If50b2a3091a468f880b42fd2385f1b74c30d2f2b
    Reviewed-on: https://code.wireshark.org/review/10700
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  f52d1d5   wslua: do not pop from empty stack on newer LUA versions
    adds  1d0532f   qt: warn when jumping to an invalid packet number


Summary of changes:
 ui/qt/packet_list.cpp |    1 +
 1 file changed, 1 insertion(+)