Wireshark-commits: [Wireshark-commits] master 1a949ba: NCP2222: change ncp.nds_return_all_classes f

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Sep 2015 21:48:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a949ba87bd6f48f666ab203ce509a918f583bc5
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1a949ba by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    NCP2222: change ncp.nds_return_all_classes filter type from FT_STRING to FT_UINT32
    
    Otherwise a call to proto_tree_add_uint_format_value will trigger an assert
    
    Bug: 11550
    Change-Id: Ic30b07a424cd94b861cee8999b91154ceeb72469
    Reviewed-on: https://code.wireshark.org/review/10689
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4ea7a9a   Qt: Add F5 as shortcut to refresh interfaces
    adds  1a949ba   NCP2222: change ncp.nds_return_all_classes filter type from FT_STRING to FT_UINT32


Summary of changes:
 tools/ncp2222.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)