Wireshark-commits: [Wireshark-commits] master 741ee8c: Arguably, some sort of assert belongs there.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Sep 2015 19:13:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=741ee8cce595866746a9da4d9d094729a42551c1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

741ee8c by Guy Harris (guy@xxxxxxxxxxxx):

    Arguably, some sort of assert belongs there.
    
    Passing a null pointer probably means there's really something else
    wrong at a higher level.  If we could arrange that the DISSECTOR_ASSERT
    macros do something useful when *not* executed during a dissection, that
    would work.
    
    Change-Id: I2605d1e1f97d35370736852aaf29eeaf2c560279
    Reviewed-on: https://code.wireshark.org/review/10592
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1d6710f   Return NULL from routines that return pointers, for stylistic consistency.
    adds  741ee8c   Arguably, some sort of assert belongs there.


Summary of changes:
 epan/packet.c |    2 ++
 1 file changed, 2 insertions(+)