Wireshark-commits: [Wireshark-commits] master a4c2a29: [iax2] don't THROW() an exception from a dis

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 Sep 2015 11:51:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a4c2a29a9cdfbe663e637649ae1dc8cc6f8e5c49
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a4c2a29 by Martin Kaiser (wireshark@xxxxxxxxx):

    [iax2] don't THROW() an exception from a dissector
    
    in this case, it's enough to exit the switch block and try to continue
    with the next element
    
    we might now end up with ie_item==NULL after the switch, so replace the
    assertion with a check
    
    Change-Id: Id54346077eb8aa12b22575f3ab6fa80087f240ce
    Reviewed-on: https://code.wireshark.org/review/10549
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5fa0bb2   change the representation of an empty byte array in a display filter
    adds  a4c2a29   [iax2] don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-iax2.c |   30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)