URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eed56ee5ec0b10a05d0655979dce6f472ced97fa
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
eed56ee by Evan Huus (eapache@xxxxxxxxx):
bootp: simplify avaya parameter parsing
Only make one pass through the parameter list, adding fields as we go. Use a
wmem_strbuf to simplify string construction. Extract the "add a param" switch
into its own function so it can be called from two different places.
Should be far easier to reason about, and much more efficient.
Change-Id: I0818e0b98cbc6d2025c776bce82e56fb72e8753a
Reviewed-on: https://code.wireshark.org/review/10505
Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Uli Heilmeier <openid@xxxxxxxxxxxx>
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Actions performed:
from 0a86b65 Qt: remove unused variables in IAX2 analysis code
adds eed56ee bootp: simplify avaya parameter parsing
Summary of changes:
epan/dissectors/packet-bootp.c | 193 ++++++++++++++++++----------------------
1 file changed, 88 insertions(+), 105 deletions(-)