Wireshark-commits: [Wireshark-commits] master 0a3d0c5: NFS file handle crc32_ccitt hashes are incor

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 Sep 2015 23:31:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0a3d0c589fc7aa4d3b8cc5c588716fa7e09448a7
Submitter: ronnie sahlberg (ronniesahlberg@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0a3d0c5 by cturney (cturney@xxxxxxxxxxx):

    NFS file handle crc32_ccitt hashes are incorrect
    
    tvb_get_string_enc() treats the FH as an an ASCII string and thus stops
    reading at the first zero (0) it encounters.
    
    Replace 'tvb_get_string_enc()' with 'tvb_memdup()' in dissect_fhandle_data().
    
    Change-Id: Ifc30ec41590e9cab5666d0988fab1f66040ce0c7
    Reviewed-on: https://code.wireshark.org/review/10493
    Reviewed-by: Cal Turney <cturney@xxxxxxxxxxx>
    Reviewed-by: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
    

Actions performed:

    from  46b50b4   SCSI: Fix decode of DeviceIdentification VPD page  it was completely bogus
    adds  0a3d0c5   NFS file handle crc32_ccitt hashes are incorrect


Summary of changes:
 epan/dissectors/packet-nfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)