Wireshark-commits: [Wireshark-commits] master e438374: Qt: Fixed a resource leak in updateSelection

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Sep 2015 06:32:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4383749906bf7ecdf221ba02d9793990865cf26
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e438374 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fixed a resource leak in updateSelectionStatus
    
    Avoid passing a reference to a allocated QString, which will
    never be deleted.
    
    This fixes a 16 Bytes leak each time an element is selected or
    deselected in the packet tree.
    
    Change-Id: If0d7482bf505fda8802dd58e8d1841b7da6b6294
    Reviewed-on: https://code.wireshark.org/review/10393
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  91d863c   Qt: Fix use-after-free pattern
    adds  e438374   Qt: Fixed a resource leak in updateSelectionStatus


Summary of changes:
 ui/qt/proto_tree.cpp |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)