Wireshark-commits: [Wireshark-commits] master 7e817ae: Require dissectors for all ONC RPC calls and

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Jul 2015 06:24:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e817aeb3a3cee7c3eb3e7685ab0ccf98a00411b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7e817ae by Guy Harris (guy@xxxxxxxxxxxx):

    Require dissectors for all ONC RPC calls and replies.
    
    Either there's a known body for the call or reply, in which case we
    already have a dissector for it, or the body is empty, in which case we
    now have dissect_rpc_void() to dissect it, or the body is unknown or
    nobody's bothered writing it, in which case we use dissect_rpc_unknown()
    for now.
    
    This means that an attempt to look up the dissector for a known
    procedure will always succeed, so we can label it with the name rather
    than with "proc-N".
    
    It also means that we distinguish between "it's void" and "it's
    unknown", so that unknown values will get flagged as such.
    
    Change-Id: I748580c1dca61d1f0972396db1a3b0885fc0a541
    Reviewed-on: https://code.wireshark.org/review/9699
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  75d4fa2   Cleanup pcapng.c file
    adds  7e817ae   Require dissectors for all ONC RPC calls and replies.


Summary of changes:
 epan/dissectors/packet-bootparams.c      |    3 +-
 epan/dissectors/packet-clearcase.c       |    5 +-
 epan/dissectors/packet-fmp.c             |    5 +-
 epan/dissectors/packet-fmp_notify.c      |    6 +-
 epan/dissectors/packet-gluster_cli.c     |   70 +++++++++++-----------
 epan/dissectors/packet-gluster_pmap.c    |   15 +++--
 epan/dissectors/packet-glusterd.c        |   82 +++++++++++++++-----------
 epan/dissectors/packet-glusterfs.c       |   74 +++++++++++++-----------
 epan/dissectors/packet-glusterfs_hndsk.c |   28 ++++++---
 epan/dissectors/packet-hclnfsd.c         |   15 +++--
 epan/dissectors/packet-kadm5.c           |   45 +++++++--------
 epan/dissectors/packet-klm.c             |    1 -
 epan/dissectors/packet-mount.c           |   53 +++++++++--------
 epan/dissectors/packet-nfs.c             |    8 +--
 epan/dissectors/packet-nfsacl.c          |    7 +--
 epan/dissectors/packet-nfsauth.c         |    5 +-
 epan/dissectors/packet-nisplus.c         |   12 ++--
 epan/dissectors/packet-nlm.c             |   93 +++++++++++++++---------------
 epan/dissectors/packet-pcnfsd.c          |   38 ++++++------
 epan/dissectors/packet-portmap.c         |   51 ++++++++--------
 epan/dissectors/packet-rpc.c             |   52 +++++++++++++----
 epan/dissectors/packet-rpc.h             |    4 ++
 epan/dissectors/packet-rquota.c          |    5 +-
 epan/dissectors/packet-rstat.c           |   25 ++++----
 epan/dissectors/packet-rwall.c           |    2 +-
 epan/dissectors/packet-sadmind.c         |    7 +--
 epan/dissectors/packet-spray.c           |    9 ++-
 epan/dissectors/packet-stat-notify.c     |    6 +-
 epan/dissectors/packet-stat.c            |    8 +--
 epan/dissectors/packet-teklink.c         |   24 ++++----
 epan/dissectors/packet-vxi11.c           |   11 ++--
 epan/dissectors/packet-ypbind.c          |   13 +++--
 epan/dissectors/packet-yppasswd.c        |    3 +-
 epan/dissectors/packet-ypserv.c          |   28 +++++----
 epan/dissectors/packet-ypxfr.c           |    6 +-
 35 files changed, 437 insertions(+), 382 deletions(-)