Wireshark-commits: [Wireshark-commits] master 4f1b8d7: Add a bounds check.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Jul 2015 18:50:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f1b8d74338ca2a6ded8498e9d87cbc3294454c0
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4f1b8d7 by Guy Harris (guy@xxxxxxxxxxxx):

    Add a bounds check.
    
    AirPDcapStoreSa() was assuming that ctx->first_free_index would always
    be within the ctx->sa array; nothing guarantees that.  Fail if it's past
    the end of the array; that means there *are* no free indices.
    
    Change-Id: I73145ea3f3dda1b3800a41fa3a2b01ac344dcbfc
    Reviewed-on: https://code.wireshark.org/review/9634
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9230834   Don't copy zero bytes of data.
    adds  4f1b8d7   Add a bounds check.


Summary of changes:
 epan/crypt/airpdcap.c |    4 ++++
 1 file changed, 4 insertions(+)