URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b19846d40eff42c28f8209e07f9c193736710749
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
b19846d by Hadriel Kaplan (hadrielk@xxxxxxxxx):
RTCP heuristic only matches odd port-number TURN ChannelData packets
RTCP can be carried within TURN CannelData messages, or STUN/TURN Send
messages. The TURN message can be in UDP or TCP, of any port number (by
default the even port 3478). So the RTCP heuristic dissector used inside the
TURN ChannelData/Send payload needs to match regardless of the port number of
the packet.
Bug: 11336
Change-Id: I155b87c3e666478d3245366784d7d4e49c8e42c8
Reviewed-on: https://code.wireshark.org/review/9624
Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from 873d598 stun/turn: stop STUN heuristic incorrectly matching TURN ChannelData messages
adds b19846d RTCP heuristic only matches odd port-number TURN ChannelData packets
Summary of changes:
epan/dissectors/packet-rtcp.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)