Wireshark-commits: [Wireshark-commits] master 5cd7601: tftp: stop TFTP heuristic incorrectly matchi

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Jul 2015 03:00:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5cd76010d90ed262698eedbac637088d5a407e1a
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5cd7601 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    tftp: stop TFTP heuristic incorrectly matching TURN ChannelData messages
    
    Make TURN-based TFTP heuristic dissector check for valid opcode and error code
    before matching TURN payload content.
    
    The TFTP heuristic dissector incorrectly matched TURN ChannelData message data
    content when it shouldn't. Unfortunately, the TFTP protocol has very little
    constrained structure to perform heuristic detection with. It basically
    always matched/succeeded.
    
    Bug: 11335
    Change-Id: I950fd5a273fef63d7b069c87d1146cbd752c3bd9
    Reviewed-on: https://code.wireshark.org/review/9489
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  cab4450   The toolkit is called "Qt", not "QT".
    adds  5cd7601   tftp: stop TFTP heuristic incorrectly matching TURN ChannelData messages


Summary of changes:
 epan/dissectors/packet-tftp.c |   86 +++++++++++++++++++++++++++++------------
 1 file changed, 62 insertions(+), 24 deletions(-)