Wireshark-commits: [Wireshark-commits] master-1.12 fad97e3: terminate readlink result

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 11 Jul 2015 18:19:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fad97e314f5f7ae369f05eea630ba1cda589a404
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

fad97e3 by Tobias Stoeckmann (tobias@xxxxxxxxxxxxxx):

    terminate readlink result
    
    The readlink function does not guarantee to nul-terminate its result string.
    Therefore, it should be done in wsutil/filesystem.c.
    
    Change-Id: Id96533e825a302a1922ce9ac7ee47d5525ac9c39
    Reviewed-on: https://code.wireshark.org/review/9597
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit a68518f4996310792860628b5f860d0005cd4f6a)
    Reviewed-on: https://code.wireshark.org/review/9600
    

Actions performed:

    from  8354b0e8  MySQL: dissector adds packet content to INFO column without scrubbing it
    adds  fad97e3   terminate readlink result


Summary of changes:
 wsutil/filesystem.c |   18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)