Wireshark-commits: [Wireshark-commits] master 131e0ab: Handle setModule(NULL) more safely.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 8 Jul 2015 23:20:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=131e0ab7ea461d519f0fbe80b03aa6bc99b9d452
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

131e0ab by Guy Harris (guy@xxxxxxxxxxxx):

    Handle setModule(NULL) more safely.
    
    If module_name is null, we can't do much of anything - we don't have a
    protocol ID, so we don't have a protocol.
    
    Change-Id: I42c2fa4b47e39d7ac122c60be91b5d408bf30a1d
    Reviewed-on: https://code.wireshark.org/review/9569
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e312d41   GTK+: Add a Telephony/ANSI menu placeholder.
    adds  131e0ab   Handle setModule(NULL) more safely.


Summary of changes:
 ui/qt/protocol_preferences_menu.cpp |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)