Wireshark-commits: [Wireshark-commits] master 80f7ee0: Call reassembly_table_destroy for some disse

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Jul 2015 23:34:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80f7ee063d371f0de989d51d40c6b4fabfbfb430
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

80f7ee0 by Peter Wu (peter@xxxxxxxxxxxxx):

    Call reassembly_table_destroy for some dissectors
    
    This patch adds reassembly_table_destroy calls as cleanup function for
    dissectors which have a simple init routine that just calls
    reassembly_table_init (comments are ignored).
    
    The changes were automatically generated using
    https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=4cc0aec05dc67a51926a045e1955b7a956757b5e
    (with the if and assignment parsers disabled).
    
    The only difference from the autogenerated output is that the XXX
    comments from the init routines in smb-pipe and tds dissectors are kept.
    
    Change-Id: I64aedf7189877247282b30b0e0f83757be6199e7
    Reviewed-on: https://code.wireshark.org/review/9222
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  750babc   rpc: use direct hashing rather than malloced ints
    adds  80f7ee0   Call reassembly_table_destroy for some dissectors


Summary of changes:
 epan/dissectors/packet-bacapp.c         |    7 +++++++
 epan/dissectors/packet-batadv.c         |    6 ++++++
 epan/dissectors/packet-ber.c            |    5 +++++
 epan/dissectors/packet-btobex.c         |    7 +++++++
 epan/dissectors/packet-capwap.c         |    6 ++++++
 epan/dissectors/packet-cell_broadcast.c |    6 ++++++
 epan/dissectors/packet-clnp.c           |    7 +++++++
 epan/dissectors/packet-dcp-etsi.c       |    7 +++++++
 epan/dissectors/packet-dtn.c            |    6 ++++++
 epan/dissectors/packet-eap.c            |    7 +++++++
 epan/dissectors/packet-gsm_cbch.c       |    7 +++++++
 epan/dissectors/packet-gsm_sms_ud.c     |    7 +++++++
 epan/dissectors/packet-gssapi.c         |    7 +++++++
 epan/dissectors/packet-ieee80211.c      |    7 +++++++
 epan/dissectors/packet-ip.c             |    7 +++++++
 epan/dissectors/packet-ipv6.c           |    7 +++++++
 epan/dissectors/packet-isup.c           |    7 +++++++
 epan/dissectors/packet-lapdm.c          |    7 +++++++
 epan/dissectors/packet-lapsat.c         |    7 +++++++
 epan/dissectors/packet-ltp.c            |    6 ++++++
 epan/dissectors/packet-mbim.c           |    7 +++++++
 epan/dissectors/packet-mp2t.c           |    6 ++++++
 epan/dissectors/packet-mq.c             |    6 ++++++
 epan/dissectors/packet-mux27010.c       |   10 +++++++---
 epan/dissectors/packet-ndmp.c           |    7 +++++++
 epan/dissectors/packet-netbios.c        |   10 +++++++---
 epan/dissectors/packet-openvpn.c        |    7 +++++++
 epan/dissectors/packet-pop.c            |    6 ++++++
 epan/dissectors/packet-ppi.c            |    7 +++++++
 epan/dissectors/packet-q931.c           |    7 ++++++-
 epan/dissectors/packet-reload.c         |    7 +++++++
 epan/dissectors/packet-rtp.c            |    7 +++++++
 epan/dissectors/packet-scsi.c           |    7 +++++++
 epan/dissectors/packet-selfm.c          |    8 +++++++-
 epan/dissectors/packet-ses.c            |    6 ++++++
 epan/dissectors/packet-smb-direct.c     |    7 +++++++
 epan/dissectors/packet-smb-pipe.c       |    7 +++++++
 epan/dissectors/packet-smtp.c           |    7 +++++++
 epan/dissectors/packet-sna.c            |    7 +++++++
 epan/dissectors/packet-sndcp.c          |    7 +++++++
 epan/dissectors/packet-stt.c            |    7 +++++++
 epan/dissectors/packet-tds.c            |    7 +++++++
 epan/dissectors/packet-teamspeak2.c     |    6 ++++++
 epan/dissectors/packet-tipc.c           |    7 +++++++
 epan/dissectors/packet-usb-audio.c      |    7 +++++++
 epan/dissectors/packet-wai.c            |    6 ++++++
 epan/dissectors/packet-wtp.c            |    7 +++++++
 epan/dissectors/packet-x25.c            |    7 +++++++
 epan/dissectors/packet-zbee-aps.c       |    7 +++++++
 49 files changed, 329 insertions(+), 8 deletions(-)