Wireshark-commits: [Wireshark-commits] master b591f07: SMB2 - An out-of-order entry in smb2_ioctl_v

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 2 Jul 2015 04:41:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b591f07273f4e055a286ca36b6fda5da99952b5d
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b591f07 by cturney (cturney@xxxxxxxxxxx):

    SMB2 - An out-of-order entry in smb2_ioctl_vals[] causes run-time error.
    
    In value string table "smb2_ioctl_vals[]" of packet-smb2.c
    
    {0x0011C017, "FSCTL_PIPE_TRANSCEIVE" } was placed before
    {0x00110018, "FSCTL_PIPE_WAIT"}
    
    which causes "Extended value string 'smb2_ioctl_vals[]' forced to fall back
    to linear search: entry , value 0x00110018 < previous entry, value
    0x0011C017"
    
    Change-Id: I99afe5aa12c031e90bb0bd4c8e8aadfffad0135d
    Reviewed-on: https://code.wireshark.org/review/9449
    Reviewed-by: Cal Turney <cturney@xxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  a66714b   Fix Buffer overrun while writing to 'airpcap_dir_utf16':  the writable size is '520' bytes, but '1042' bytes might be written.
    adds  b591f07   SMB2 - An out-of-order entry in smb2_ioctl_vals[] causes run-time error.


Summary of changes:
 epan/dissectors/packet-smb2.c |    5 +++++
 1 file changed, 5 insertions(+)