Wireshark-commits: [Wireshark-commits] master 9c7acde: opcua dissector: Fix parsing of 7 byte numer

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 1 Jul 2015 11:13:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c7acde7125b23fa8c74bd9f6f98a7e940e5c5c8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9c7acde by Gerhard Gappmeier (gerhard.gappmeier@xxxxxxxxxxx):

    opcua dissector: Fix parsing of 7 byte numeric service NodeIds.
    
    The service NodeIds of OPC UA are normally encoded as 4 byte numeric NodeId.
    However, it is technically also possible to encode these as (less efficient) 7 byte numeric NodeId.
    This kind of NodeId was already implemented, but wrong.
    Since then no one ever used this kind of NodeId for service NodeIds.
    
    Change-Id: I8654d969604e18bce8415931e455632e72d578ef
    Reviewed-on: https://code.wireshark.org/review/9435
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fbf0c34   Try to fix some warnings from Visual Studio Code Analysis.
    adds  9c7acde   opcua dissector: Fix parsing of 7 byte numeric service NodeIds.


Summary of changes:
 plugins/opcua/opcua_application_layer.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)