Wireshark-commits: [Wireshark-commits] master a6f9cf5: Don't free col_item->col_data.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 29 Jun 2015 18:15:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6f9cf568238a25116973be69da2556b56d27d7f
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a6f9cf5 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Don't free col_item->col_data.
    
    It either points to col_item->col_buf (which we explicitly free) or to
    a static string.
    
    Change-Id: I4d6db3fa16e69a4321be9d01076026c024df9a00
    Reviewed-on: https://code.wireshark.org/review/9219
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  0b0100b   Fixup the packet list navigation action behavior.
    adds  a6f9cf5   Don't free col_item->col_data.


Summary of changes:
 epan/column-utils.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)