Wireshark-commits: [Wireshark-commits] master e4dc332: Set 802.11.ac Partial AID field size

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 28 Jun 2015 12:21:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4dc3321b1962d3cfaf25240b647b5403d6aaef3
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e4dc332 by Graham Bloice (graham.bloice@xxxxxxxxxxxxx):

    Set 802.11.ac Partial AID field size
    
    The assignment of a short to a guint8 in packet-ieee80211-radiotap.c line 1696
    generates a narrowing warning.
    
    In my reading of the spec which shows the field as 9 bits,
    and looking at the hf fields for this item I think it should be a guint16.
    
    Change-Id: Ic7785c2bfc66d72f7b1e914b1a46f32079fc99d9
    Reviewed-on: https://code.wireshark.org/review/9197
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Petri-Dish: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  d4bdbb9   1.5.17 seems to be a typo. Change it to the probably intended 1.6.17
    adds  e4dc332   Set 802.11.ac Partial AID field size


Summary of changes:
 wiretap/wtap.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)