URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0901e26505ca57b8331aa3edc9e43f1f087a3d77
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
0901e26 by Pascal Quantin (pascal.quantin@xxxxxxxxx):
Qt: change default behavior of 'Decode As' window
Up to know Qt 'Decode As' window was saving manual configuration automatically, contrary to GTK UI.
This can be misleading when decoding protocols without a fixed identifier (port number, USB bus/device id, ...).
Opening a new trace might lead to previous and now irrelevant settings being applied.
Make this optional and add a Save button to permanently store the current configuration.
Change-Id: I077c560f9e71cab16a74247e2e9d87523c0ed85e
Reviewed-on: https://code.wireshark.org/review/9058
Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from 8bc294c Replace more deprecated tvb_length calls
adds 0901e26 Qt: change default behavior of 'Decode As' window
Summary of changes:
ui/qt/decode_as_dialog.cpp | 20 ++++++++++++++++----
ui/qt/decode_as_dialog.h | 5 +++--
ui/qt/decode_as_dialog.ui | 2 +-
3 files changed, 20 insertions(+), 7 deletions(-)