Wireshark-commits: [Wireshark-commits] master ce9c1df: coverity 1306905: integer overflowed argumen

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 23 Jun 2015 03:36:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce9c1dfd07539055d888e0e95c08f47cb193d995
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ce9c1df by Martin Kaiser (wireshark@xxxxxxxxx):

    coverity 1306905: integer overflowed argument
    
    tvb_strsize() returns guint
    remove the if (tree) while we're at it
    
    Change-Id: Icc24f166104a3e9b95fca2ef14a7bd8be2677cba
    Reviewed-on: https://code.wireshark.org/review/9047
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  db72eb4   wmem_tree_new_autoreset() never returns NULL
    adds  ce9c1df   coverity 1306905: integer overflowed argument


Summary of changes:
 epan/dissectors/packet-fcfcs.c |   56 +++++++++++++++++++---------------------
 1 file changed, 27 insertions(+), 29 deletions(-)