Wireshark-commits: [Wireshark-commits] master fd82fd4: NFSv4: A zero attribute mask is acceptable i

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Jun 2015 06:00:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd82fd467f0d4863c15af926f19b42f1ea1995b8
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fd82fd4 by cturney (cturney@xxxxxxxxxxx):

    NFSv4: A zero attribute mask is acceptable in dissect_nfs4_fattrs() if
    'type' = FATTR4_BITMAP_ONLY
    
    This patch updates the code accordingly.
    
    
    Vars 'num_bitmaps', and 'count' are declared as guint8 but being passed to
    32-bit fields of proto_tree_add_uint() and tvb_ensure_bytes_exist(). In
    glibconfig.h 'guint8' is defined as 'typedef unsigned char guint8;' and in
    'limits.h', ‘char’ is defined as 8 bits: #define CHAR_BIT 8  /* number of
    bits in a char */. These vars have been changed to 32-bits.
    
    There are 22 other dissectors that call "tvb_ensure_bytes_exist()". In
    addition, there are an 215 CHECK_BYTE_COUNT_SUBR macro calls in
    packet-smb.c which essentially do the same thing. README.developer does
    state "you can check whether the data is present by using
    "tvb_ensure_bytes_exist()" although this frequently is not needed." This
    call has been removed in accordance with that statement.
    
    Bug: 10483
    Change-Id: Ib06ab14254882e9110af265d2d67a66dcce694f2
    Reviewed-on: https://code.wireshark.org/review/8847
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  f389fb5   It's INVALID_HANDLE_VALUE, not INVALID_HANDLE.
    adds  fd82fd4   NFSv4: A zero attribute mask is acceptable in dissect_nfs4_fattrs() if 'type' = FATTR4_BITMAP_ONLY


Summary of changes:
 epan/dissectors/packet-nfs.c |   28 +++++++++++++++++-----------
 1 file changed, 17 insertions(+), 11 deletions(-)