[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69dac892803cdc555648c0a085ae2770942f0ae2
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

69dac89 by Peter Wu (peter@xxxxxxxxxxxxx):

    tcp: simplify tcp.flags.str, fix off-by-one
    
    Observe that tcp_flags_to_str_first_letter is a copy of tcp_flags_to_str
    with the flags[][4] variables copied and the loop variables inverted.
    This misses the FIN bit, and runs past the flags buffer.
    
    Behavior change: for consistency, move the reserved bits to the front
    and print reserved bits individually. Old output / new output:
    
        NCEUAPRSRRR
        RRRNCEUAPRSF
    
    Tested with this pcap with all flag bits set (0x0fff). hexdump:
    
        d4c3b2a1020004000000000000000000ff7f000065000000b6b77455f3ac
        06002800000028000000450000280001000040067ccd7f0000017f000001
        0014005000000000000000005fff2000907f0000
    
    Change-Id: I70e070808d1f0f9cd60eaf4f2b3f4ac6e3cfaada
    Reviewed-on: https://code.wireshark.org/review/8826
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  09e3505   Profinet: OEM Device ID is added
    adds  69dac89   tcp: simplify tcp.flags.str, fix off-by-one


Summary of changes:
 epan/dissectors/packet-tcp.c |   31 +++++++++----------------------
 1 file changed, 9 insertions(+), 22 deletions(-)