Wireshark-commits: [Wireshark-commits] master ac9f248: SKYPE: fix The use of 'if (A) {...} else if

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 6 Jun 2015 14:22:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac9f248d8109aecd73697302f917206fe51810b7
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ac9f248 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    SKYPE: fix The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence found by PVS Studio (V517).
    
    Yes, there is a bug ! :-)
    
    Change-Id: I16319e6441575b9d7b702e6b23f7a7996ef85523
    Reviewed-on: https://code.wireshark.org/review/8793
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  027b0cb   SMB2: There are identical sub-expressions to the left and to the right of the '&&' operator: si && si->saved && si->saved found by PVS Studio (V501)
    adds  ac9f248   SKYPE: fix The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence found by PVS Studio (V517).


Summary of changes:
 epan/dissectors/packet-skype.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)