Wireshark-commits: [Wireshark-commits] master 78593c2: NFS: Fix NFSv4 attribute offsets and lengths

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 22 May 2015 14:06:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=78593c2e91e7c69ad9eb9a16f5508e704e4035e5
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

78593c2 by Andreas Gruenbacher (andreas.gruenbacher@xxxxxxxxx):

    NFS: Fix NFSv4 attribute offsets and lengths
    
    NFSv4 attributes are transferred as a bitmask, followed by each of the
    attributes in the bitmask.  The offset and length of the dissected attribute
    values should point at where the attribute values are; instead, they were
    pointing at the bitmap. Fix that.
    
    Change-Id: I4f93b7fffd7497306ae828a2fbd3c0e9b0accd1c
    Reviewed-on: https://code.wireshark.org/review/8536
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  03577f6   NFS: Dissect NFSv4.1 dacl and sacl attributes
    adds  78593c2   NFS: Fix NFSv4 attribute offsets and lengths


Summary of changes:
 epan/dissectors/packet-nfs.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)