URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2156413bf9cb093b7f5998399bb6ceb7b4c232ce
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
2156413 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Column preference fixes.
Don't call redrawVisiblePackets in PacketList::sectionResized. Otherwise
we trigger the crash in bug 11179. Call recent_set_column_width instead.
Clean up the slots called when column preferences change and when recent
column widths change.
Update our column visibility in redrawVisiblePackets.
Use recent_get_column_width when writing the recent file. columnWidth
doesn't return a valid value when we're not visible.
Bug: 11179.
Change-Id: I34ab93d944b341e42129a1c8ff94ba8f7ad4f5fc
Reviewed-on: https://code.wireshark.org/review/8457
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from 2793069 Add a comment explaining completion misbehavior.
adds 2156413 Qt: Column preference fixes.
Summary of changes:
ui/qt/main_window.cpp | 4 +++-
ui/qt/main_window_slots.cpp | 1 +
ui/qt/packet_list.cpp | 27 ++++++++++++---------------
ui/qt/packet_list.h | 3 ++-
ui/qt/wireshark_application.cpp | 2 +-
5 files changed, 19 insertions(+), 18 deletions(-)