Wireshark-commits: [Wireshark-commits] master 5862c94: In the name of God and all that is holy, don

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 May 2015 00:23:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5862c94e901beb828125f39233cec2696ef14be2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5862c94 by Guy Harris (guy@xxxxxxxxxxxx):

    In the name of God and all that is holy, don't do that.
    
    	http://www.bitterfilms.com/rejected.html
    
    1) There is *NO* guarantee that you can safely dereference a misaligned
    pointer.
    
    2) There is *NO* guarantee that you are running on a little-endian
    machine, so that an attempt to fetch a 32-bit integer through such a
    pointer will fetch it in little-endian form.
    
    Instead, fetch it using tvb_letohl(), which 1) doesn't care about
    alignment and 2) always fetches in little-endian order.
    
    Change-Id: I30ad6607b7c6d5047245bfcfdcbe757b02d02172
    Reviewed-on: https://code.wireshark.org/review/8422
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a0046c3   Qt: Expert info → Expert information.
    adds  5862c94   In the name of God and all that is holy, don't do that.


Summary of changes:
 epan/dissectors/packet-mq.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)