Wireshark-commits: [Wireshark-commits] master-1.12 d989452: Do not assume the data field of an addr

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 11 May 2015 23:40:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d9894524308f06d659d73fde44f77a6d1aa28cf4
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

d989452 by Guy Harris (guy@xxxxxxxxxxxx):

    Do not assume the data field of an address structure is an aligned pointer.
    
    There is *no* guarantee that it's aligned on a 4-byte boundary, and
    there is *no* guarantee that you can safely dereference an unaligned
    pointer.  See bug 11172 for a crash on Solaris/SPARC caused by those
    assumptions both being false.
    
    Change-Id: I001a71bf060f00c48ae5c586dea6cc3463d49d9a
    Reviewed-on: https://code.wireshark.org/review/8415
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e8469d3   MEGACO - remember "short form" format and don't recheck it.
    adds  d989452   Do not assume the data field of an address structure is an aligned pointer.


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)