Wireshark-commits: [Wireshark-commits] master f1e7367: giop: ignore NULL-terminator in CDR strings

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 11 May 2015 04:28:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f1e736772b90efc3cadbd8051f1153c88ad6ab7d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f1e7367 by Evan Huus (eapache@xxxxxxxxx):

    giop: ignore NULL-terminator in CDR strings
    
    CDR strings appear to be both counted *and* NULL-terminated in many cases,
    which is rather weird, so if we see a NULL-terminator, ignore it in the count;
    otherwise we print a trailing '\000' on all the strings we put in the tree.
    
    Bug: 11126
    Change-Id: I45b6b414683a6f646d37c2e2001b7319d5c80be5
    Reviewed-on: https://code.wireshark.org/review/8390
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e997aaa   packet-cipmotion.c: Modified CIP motion parser
    adds  f1e7367   giop: ignore NULL-terminator in CDR strings


Summary of changes:
 epan/dissectors/packet-giop.c |    3 +++
 1 file changed, 3 insertions(+)