Wireshark-commits: [Wireshark-commits] master db34120: airpdcap: ensure that buffer put on stack is

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 8 May 2015 19:21:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db3412051ff3e20526f2f4bbf11271da4d70ef56
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

db34120 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    airpdcap: ensure that buffer put on stack is big enough to hold the result of AirPDcapRsnaPwd2PskStep()
    
    g1439eb6 changed AIRPDCAP_WPA_PSK_LEN from 64 bytes to 32 bytes, leading to a stack corruption in AirPDcapRsnaPwd2Psk() function
    
    Change-Id: Ibf51f6749715055cd84906a144214ed44c85256b
    Reviewed-on: https://code.wireshark.org/review/8358
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  dce4cc6   GTPv2: fix unused parameter 'pinfo' warning
    adds  db34120   airpdcap: ensure that buffer put on stack is big enough to hold the result of AirPDcapRsnaPwd2PskStep()


Summary of changes:
 epan/crypt/airpdcap.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)