Wireshark-commits: [Wireshark-commits] master 7771ed2: Fix detection of 'Write Multiple Registers'

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 7 May 2015 08:26:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7771ed2faabd60975151ee131f1c67459c50eb54
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7771ed2 by cbontje (cbontje@xxxxxxxxx):

    Fix detection of 'Write Multiple Registers' and 'Write Multiple Coils' function message 'direction'
    
    Also did some refactoring of existing code to make it more readable for the various existing function code types.
    
    ** Commit amendment to not use depreciated tvb_length() function.
    
    Change-Id: Ia4c9f3514968c2a7bebc404ca9185cf8d814dfca
    Reviewed-on: https://code.wireshark.org/review/8301
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c3c4d42   Reduce proto_tree_add_text calls in packet-sigcomp.c
    adds  7771ed2   Fix detection of 'Write Multiple Registers' and 'Write Multiple Coils' function message 'direction'


Summary of changes:
 epan/dissectors/packet-mbtcp.c |   58 +++++++++++++++++++++++++++++-----------
 1 file changed, 43 insertions(+), 15 deletions(-)