URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a308e737deba7ffff5bf07d49e8e294cc9ddb4a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
7a308e7 by Guy Harris (guy@xxxxxxxxxxxx):
Fix some cases where we're shifting a signed 1 left.
Shift 1U instead, to make sure it's unsigned; the result of, for
example, the result of shifting a signed value left is undefined if the
value times 2^{shift count} doesn't fit in the *signed* type of the
shifted value. That means, in particular, that the result of shifting 1
left by {number of bits in an int - 1} is undefined. (In *practice*,
it'll probably be -2^32, with the bit you want set, but that's not
guaranteed, and GCC 5.1 seems not to like it.)
Change-Id: I96114047d402d1bae537cdfeb28a8564b1c94712
Reviewed-on: https://code.wireshark.org/review/8256
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 9fba5f0 Fix some cases where we're shifting a signed 1 left.
adds 7a308e7 Fix some cases where we're shifting a signed 1 left.
Summary of changes:
epan/dissectors/packet-ieee80211-radiotap.c | 2 +-
epan/dissectors/packet-smb-browse.c | 70 +++++++++++++--------------
2 files changed, 36 insertions(+), 36 deletions(-)