Wireshark-commits: [Wireshark-commits] master d074ed1: Just use g_strdup_printf() to create a g_mal

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Apr 2015 05:05:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d074ed17e1431e90f3fd3baeee5925866d514432
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d074ed1 by Guy Harris (guy@xxxxxxxxxxxx):

    Just use g_strdup_printf() to create a g_mallocated formatted string.
    
    And, as it's g_mallocated, we don't need to g_mallocate it again with
    g_strdup().
    
    The same is true of strings allocated with g_strconcat().  Don't make an
    extra copy, and don't free up the original.
    
    Change-Id: Iea470a4424a811934f7fb8b0ba8dd110d337e420
    Reviewed-on: https://code.wireshark.org/review/8058
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  eeed4d1   UI: Implementing menus for plugins
    adds  d074ed1   Just use g_strdup_printf() to create a g_mallocated formatted string.


Summary of changes:
 epan/ext_menubar.c |   18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)