Wireshark-commits: [Wireshark-commits] master 9d10be5: Some CANopen frame types can have zero size,

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 4 Apr 2015 13:01:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d10be54c7b1540642848c7ea1d273a7acbf229a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9d10be5 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Some CANopen frame types can have zero size, so use tvb_reported_length instead of -1.
    
    Bug: 11083
    Change-Id: Ib17649fbbc4f79705e3ad18903b5c8847cb09054
    Reviewed-on: https://code.wireshark.org/review/7881
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  267e169   try to silence the OS X builbots by renaming index to idx
    adds  9d10be5   Some CANopen frame types can have zero size, so use tvb_reported_length instead of -1.


Summary of changes:
 epan/dissectors/packet-canopen.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)