Wireshark-commits: [Wireshark-commits] master-1.12 d9ee3f7: Rename update_interface_list() and remo

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Mar 2015 10:23:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d9ee3f79589e2cc2662637356dbadf0d73864230
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

d9ee3f7 by Guy Harris (guy@xxxxxxxxxxxx):

    Rename update_interface_list() and remove local interface code from it.
    
    It's only used to update the remote interface list, and never updates
    anything else (it sets iftype_id to CAPTURE_IFREMOTE and never changes
    it, so all tests for whether iftype_id is == or >= CAPTURE_IFREMOTE
    succeed); remove the code that would be executed if, somehow, iftype_id
    got stomped on, and rename it to update_remote_interface_list().
    
    Change-Id: Idebb530dfc4e8bb4fbab5d8315c07e1c10961453
    Reviewed-on: https://code.wireshark.org/review/7775
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  db273d0   MBIM: fix a typo
    adds  d9ee3f7   Rename update_interface_list() and remove local interface code from it.


Summary of changes:
 ui/gtk/capture_dlg.c |   40 +++++++++++++++-------------------------
 1 file changed, 15 insertions(+), 25 deletions(-)