Wireshark-commits: [Wireshark-commits] lts-1.12.1 e0752c2: tnef: fix overflow leading to infinite l

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Mar 2015 14:25:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0752c27a7a67db2fdca6da41e770a5ab41a967b
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

e0752c2 by Evan Huus (eapache@xxxxxxxxx):

    tnef: fix overflow leading to infinite loop
    
    Thanks to Vlad Tsyrklevich for the report, and Fabian Yamaguchi for the "joern"
    tool which found the bug.
    
    Bug: 11023
    Change-Id: I53bc998c9934736698e7db5eba09a14e79a7c633
    Reviewed-on: https://code.wireshark.org/review/7461
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit 608cf324b3962877e9699f3e81e8f82ac9f1ea14)
    Reviewed-on: https://code.wireshark.org/review/7486
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/7706
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  bf4ed6e   Pcapng: Don't fetch past the end of a GArray.
    adds  e0752c2   tnef: fix overflow leading to infinite loop


Summary of changes:
 epan/dissectors/packet-tnef.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)