Wireshark-commits: [Wireshark-commits] master-1.12 5845a54: Don't pass a t4-non-ecm-sig-end to the

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Mar 2015 17:33:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5845a54a5d00c0de0a2abf854fe0a714c60eb808
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

5845a54 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't pass a t4-non-ecm-sig-end to the tap if we didn't see the start of the
    data: the invalid frame number will crash Wireshark.
    
    Bug: 10885
    Change-Id: I3ae278b77a9449136fbaaac52f2bbaa8a510bf76
    Reviewed-on: https://code.wireshark.org/review/7651
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 283336508efad6c58ad0a62508b7e6ca5db34ece)
    Reviewed-on: https://code.wireshark.org/review/7657
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  9a24e2c   Assert that the row number passed to packet_list_get_row_data() is valid.
    adds  5845a54   Don't pass a t4-non-ecm-sig-end to the tap if we didn't see the start of the data: the invalid frame number will crash Wireshark.


Summary of changes:
 asn1/t38/t38.cnf             |    4 +++-
 epan/dissectors/packet-t38.c |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)