Wireshark-commits: [Wireshark-commits] master 44dbae7: ProtoTree: Fix crashes.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 9 Mar 2015 21:33:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=44dbae72bad1964936b626d8309d02002c665796
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

44dbae7 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    ProtoTree: Fix crashes.
    
    Don't dereference a null pointer. Remove g_assert()s copied from ui/gtk.
    This fixes problems mentioned in bug 11044 but not the bug itself.
    
    Change-Id: Iab75ab5cc6a184c8145a094b1c529a634e3c1c0d
    Ping-Bug: 11044
    Reviewed-on: https://code.wireshark.org/review/7610
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  ae8b538   Add dissection of the SMB2 FSCTL_SET_INTEGRITY_INFORMATION FSCTL based on documentation on the MS website and a capture I have.
    adds  44dbae7   ProtoTree: Fix crashes.


Summary of changes:
 ui/qt/proto_tree.cpp |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)