Wireshark-commits: [Wireshark-commits] master 4ca3dba: tcp: support variable-length tcp_dissect_pdu

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 6 Mar 2015 04:02:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ca3dbae9440c202c9b2346010c1986ee8e8968e
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4ca3dba by Peter Wu (peter@xxxxxxxxxxxxx):

    tcp: support variable-length tcp_dissect_pdus
    
    Originally suggested by Bill Meier for the MQTT protocol[1], but the
    Websocket protocol can also benefit from this. Since
    DESEGMENT_ONE_MORE_SEGMENT is a valid packet length, use the zero length
    instead as an indicator that the length is not yet known.
    
    Updated documentation too and remove the function documentation from
    packet-tcp.c since it is duplicated in packet-tcp.h.
    
    A noteworthy WSDG change is that the get_pdu_len parameter of
    tcp_dissect_pdus gained another void pointer since
    v1.99.2rc0-890-gceb8d95 ("Lua: Expose tcp_dissect_pdus() to Lua").
    
     [1]: https://www.wireshark.org/lists/wireshark-dev/201405/msg00044.html
    
    Change-Id: I4eba380e00cd757635eb5639c2857356dae3171e
    Reviewed-on: https://code.wireshark.org/review/7279
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  554c8fd   Reflect wsutil changes.
    adds  4ca3dba   tcp: support variable-length tcp_dissect_pdus


Summary of changes:
 doc/README.dissector                              |    9 ++++---
 docbook/wsdg_src/WSDG_chapter_dissection.asciidoc |   27 ++++++++++++--------
 epan/dissectors/packet-tcp.c                      |   28 ++++++++-------------
 epan/dissectors/packet-tcp.h                      |    3 ++-
 4 files changed, 34 insertions(+), 33 deletions(-)