Wireshark-commits: [Wireshark-commits] master-1.12 8b14004: [ICMP] Don't use icmp_original_dgram_le

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 5 Mar 2015 16:35:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b1400410e8bcfbe36d8a253d66bf60b57a41de9
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

8b14004 by Anish Bhatt (anish@xxxxxxxxxxx):

    [ICMP] Don't use icmp_original_dgram_length for redirect packet
    
    icmp_original_dgram_length was being incorrectly used to clamp tvb size for
    ICMP redirect packet. This is a bogus value, use ip header len + 64 bits
    instead
    
    Bug: 10992
    Change-Id: Iebd70d72df34185446a239280bb19c0268977490
    Reviewed-on: https://code.wireshark.org/review/7340
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit b679295db9c468f4b3d97209c5c1f69a352d8a7a)
    Reviewed-on: https://code.wireshark.org/review/7544
    

Actions performed:

    from  f4ac38f   [ICMP] icmp_original_dgram_length is being used incorrectly
    adds  8b14004   [ICMP] Don't use icmp_original_dgram_length for redirect packet


Summary of changes:
 epan/dissectors/packet-icmp.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)