Wireshark-commits: [Wireshark-commits] master-1.12 bcba37c: GSM MAP: do not use a global variable t

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 3 Mar 2015 16:06:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bcba37c36c47887ea400a72f2b778f5929b58b92
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

bcba37c by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    GSM MAP: do not use a global variable to store OID
    
    Fixes an ASAN failure reported by Alexis
    
    Change-Id: I63b07ec4b6eb0698c4abf27f8fb0b1f11a19396d
    Reviewed-on: https://code.wireshark.org/review/7510
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 2780a303ab0e8d293bd9be88b523de1bb02b413c)
    Conflicts:
    	asn1/gsm_map/gsm_map.cnf
    	epan/dissectors/packet-gsm_map.c
    Reviewed-on: https://code.wireshark.org/review/7513
    

Actions performed:

    from  63bbd10   More 1.12.4 prep.
    adds  bcba37c   GSM MAP: do not use a global variable to store OID


Summary of changes:
 asn1/gsm_map/gsm_map.cnf               |    8 ++-
 asn1/gsm_map/packet-gsm_map-template.c |    1 -
 epan/dissectors/packet-gsm_map.c       |  116 +++++++++++++++++---------------
 3 files changed, 65 insertions(+), 60 deletions(-)