Wireshark-commits: [Wireshark-commits] master 5892d3c: Don't use ctime().

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 Feb 2015 09:15:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5892d3c42fd29f7c44520978e6cc17c116fb4985
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5892d3c by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use ctime().
    
    The API checks warn about it being deprecated - that doesn't seem to
    cause a problem with the buildbot, but does result in failures from the
    Petri dish.  Format the first and last packet time in an ISO 8601-style
    format.
    
    Call them "First packet time" and "Last packet time", rather than "Start
    time" and "End time", as they're not necessarily the times when the
    capture started or ended.
    
    (Both make the output a bit more like the Statistics -> Summary window.)
    
    Change-Id: Ibf02999851f49c7951c6f6152c70efa271414bd9
    Reviewed-on: https://code.wireshark.org/review/7442
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  65303ef   Remove some unneeded includes of <sys/time.h>.
    adds  5892d3c   Don't use ctime().


Summary of changes:
 capinfos.c |   31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)